[Checkins] [zopefoundation/zope.sqlalchemy] 51209a: Fix string comparison (use != instead of is not)
Marius Gedminas
noreply at github.com
Mon Dec 30 10:10:44 CET 2019
Branch: refs/heads/master
Home: https://github.com/zopefoundation/zope.sqlalchemy
Commit: 51209a9c15bc04cc7f3644c1c0053245280146fb
https://github.com/zopefoundation/zope.sqlalchemy/commit/51209a9c15bc04cc7f3644c1c0053245280146fb
Author: Martin Stein <mstein.mail at gmail.com>
Date: 2019-12-25 (Wed, 25 Dec 2019)
Changed paths:
M src/zope/sqlalchemy/datamanager.py
Log Message:
-----------
Fix string comparison (use != instead of is not)
Python 3.8 gives a warning for us in `zope/sqlalchemy/datamanager.py:132`:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
That warning seems correct, and the `is not` might even lead to unintended results. So this line should probably be changed to `!=` .
Commit: b2227a38ec7ff5b46cf6cdb854c6592732b8c653
https://github.com/zopefoundation/zope.sqlalchemy/commit/b2227a38ec7ff5b46cf6cdb854c6592732b8c653
Author: Marius Gedminas <marius at gedmin.as>
Date: 2019-12-30 (Mon, 30 Dec 2019)
Changed paths:
M src/zope/sqlalchemy/datamanager.py
Log Message:
-----------
Merge pull request #41 from martinstein/patch-1
Fix string comparison (use != instead of is not)
Compare: https://github.com/zopefoundation/zope.sqlalchemy/compare/47efbba0b9a1...b2227a38ec7f
More information about the checkins
mailing list