[Checkins] [zopefoundation/zope.sendmail] 65c3b4: Fix tox -e coverage

Marius Gedminas noreply at github.com
Thu Feb 7 16:20:06 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/zope.sendmail
  Commit: 65c3b4d2036301bd9a27a71afbf68db9da23d2e1
      https://github.com/zopefoundation/zope.sendmail/commit/65c3b4d2036301bd9a27a71afbf68db9da23d2e1
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-02-07 (Thu, 07 Feb 2019)

  Changed paths:
    M .coveragerc
    M src/zope/sendmail/_compat.py
    M src/zope/sendmail/mailer.py
    M src/zope/sendmail/queue.py
    M tox.ini

  Log Message:
  -----------
  Fix tox -e coverage

In a recent PR we added some lines of code that are executed under
Python 2 only.  This caused tox -e coverage to fail.

(It caused no problems for coveralls, because they merge the coverages
of all Python versions.)

Let's use the coverage-python-version plugin so we can annotate blocks
of code that are Python version specific, so that coverage will be 100%
irrespective of which Python version you use to run the tests.


  Commit: 0619e9dc78ffec2d9f6c6e32d86dd42eab577862
      https://github.com/zopefoundation/zope.sendmail/commit/0619e9dc78ffec2d9f6c6e32d86dd42eab577862
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-02-07 (Thu, 07 Feb 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Install the coverage-python-version plugin on Travis


  Commit: 3f641751d373a6eaff5bd7adc5b0a6a98736717c
      https://github.com/zopefoundation/zope.sendmail/commit/3f641751d373a6eaff5bd7adc5b0a6a98736717c
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-02-07 (Thu, 07 Feb 2019)

  Changed paths:
    M .coveragerc
    M .travis.yml
    M src/zope/sendmail/_compat.py
    M src/zope/sendmail/mailer.py
    M src/zope/sendmail/queue.py
    M tox.ini

  Log Message:
  -----------
  Merge pull request #22 from zopefoundation/fix-coverage

Fix tox -e coverage


Compare: https://github.com/zopefoundation/zope.sendmail/compare/aa2df0aee114...3f641751d373


More information about the checkins mailing list