[Checkins] [zopefoundation/zope.publisher] fb42a9: cgi.FieldStorage() already decoded our inputs

Marius Gedminas noreply at github.com
Wed Jul 10 17:40:45 CEST 2019


  Branch: refs/heads/fix-encodings-on-py3
  Home:   https://github.com/zopefoundation/zope.publisher
  Commit: fb42a9de2b3fa97d6d3643b21907fe39af762feb
      https://github.com/zopefoundation/zope.publisher/commit/fb42a9de2b3fa97d6d3643b21907fe39af762feb
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  cgi.FieldStorage() already decoded our inputs

Fixes #40, #41.  Probably badly.

See also #15, which is a smarter fix most likely.


  Commit: e2922aeff1b98902b49b501f53390ae8706053a4
      https://github.com/zopefoundation/zope.publisher/commit/e2922aeff1b98902b49b501f53390ae8706053a4
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Mangle QUERY_STRING correctly

Fixes the one failing test.

Code stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 6f162e984bea264afc3de331162ea4691322ed58
      https://github.com/zopefoundation/zope.publisher/commit/6f162e984bea264afc3de331162ea4691322ed58
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Add tests

Tests stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files
and mangled beyond recognition as is my habit.

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 795dd3239b59229227f843d867d869009abb2be7
      https://github.com/zopefoundation/zope.publisher/commit/795dd3239b59229227f843d867d869009abb2be7
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Restore our charset decoding logic

Code stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 5c9174fd05da581f7b35413f74b24f888ea4ab6e
      https://github.com/zopefoundation/zope.publisher/commit/5c9174fd05da581f7b35413f74b24f888ea4ab6e
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py
    M src/zope/publisher/tests/test_browserrequest.py
    M tox.ini

  Log Message:
  -----------
  Handle non-UTF-8 charsets


  Commit: 2dade9ad3f3dd40fbeb29d84816bfcd4d8c9567d
      https://github.com/zopefoundation/zope.publisher/commit/2dade9ad3f3dd40fbeb29d84816bfcd4d8c9567d
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Add an XXX comment

See https://github.com/zopefoundation/zope.publisher/issues/40.


  Commit: 4c26b15ac655012f68b08ebfa6423d6f99c0c7a0
      https://github.com/zopefoundation/zope.publisher/commit/4c26b15ac655012f68b08ebfa6423d6f99c0c7a0
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Fix empty file uploads


Compare: https://github.com/zopefoundation/zope.publisher/compare/fb42a9de2b3f%5E...4c26b15ac655


More information about the checkins mailing list