[Checkins] [zopefoundation/zope.publisher] ee8b65: cgi.FieldStorage() already decoded our inputs

Marius Gedminas noreply at github.com
Wed Jul 10 18:14:35 CEST 2019


  Branch: refs/heads/fix-encodings-on-py3
  Home:   https://github.com/zopefoundation/zope.publisher
  Commit: ee8b655a2111dd6f34138f3eef27d48534442688
      https://github.com/zopefoundation/zope.publisher/commit/ee8b655a2111dd6f34138f3eef27d48534442688
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  cgi.FieldStorage() already decoded our inputs

Fixes #40, #41.  Probably badly.

See also #15, which is a smarter fix most likely.


  Commit: 321ef015e113ea2eefd9300ad3307880456e9adf
      https://github.com/zopefoundation/zope.publisher/commit/321ef015e113ea2eefd9300ad3307880456e9adf
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Mangle QUERY_STRING correctly

Fixes the one failing test.

Code stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 62c01edad55ded0cd07bb843b7911487690c9bf1
      https://github.com/zopefoundation/zope.publisher/commit/62c01edad55ded0cd07bb843b7911487690c9bf1
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Add tests

Tests stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files
and mangled beyond recognition as is my habit.

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 819e6d806b9aa0c465cdc69bc8f66996a4245ec4
      https://github.com/zopefoundation/zope.publisher/commit/819e6d806b9aa0c465cdc69bc8f66996a4245ec4
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Restore our charset decoding logic

Code stolen from https://github.com/zopefoundation/zope.publisher/pull/15/files

Co-Authored-By: Brian Sutherland <brian at sutherland.es>


  Commit: 541b009efbfcbe5ba8335e815f0dd7be465a8e62
      https://github.com/zopefoundation/zope.publisher/commit/541b009efbfcbe5ba8335e815f0dd7be465a8e62
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py
    M src/zope/publisher/tests/test_browserrequest.py
    M tox.ini

  Log Message:
  -----------
  Handle non-UTF-8 charsets


  Commit: c4cb43a92264d643c8a0e7a38d26520de6e8c375
      https://github.com/zopefoundation/zope.publisher/commit/c4cb43a92264d643c8a0e7a38d26520de6e8c375
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py

  Log Message:
  -----------
  Add an XXX comment

See https://github.com/zopefoundation/zope.publisher/issues/40.


  Commit: 7d58a9c3c640daadd9b08ba11040d0c99eda00c6
      https://github.com/zopefoundation/zope.publisher/commit/7d58a9c3c640daadd9b08ba11040d0c99eda00c6
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/browser.py
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Fix empty file uploads


  Commit: fe4b7eb31ae79e1175449a10c9ade01c0cb1ff1e
      https://github.com/zopefoundation/zope.publisher/commit/fe4b7eb31ae79e1175449a10c9ade01c0cb1ff1e
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Add another test

We can never have too many tests.


Compare: https://github.com/zopefoundation/zope.publisher/compare/f8fb20eddbee...fe4b7eb31ae7


More information about the checkins mailing list