[Checkins] [zopefoundation/persistent] bae156: Fix C compilation warning

Michael Howitz noreply at github.com
Wed May 15 08:23:56 CEST 2019


  Branch: refs/heads/py34,py38
  Home:   https://github.com/zopefoundation/persistent
  Commit: bae1560d52dba696fdedc68985cadc680ac11862
      https://github.com/zopefoundation/persistent/commit/bae1560d52dba696fdedc68985cadc680ac11862
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Fix C compilation warning

gcc 8.3.0 emits this during python setup.py build:

persistent/cPersistence.c: In function ‘Per_repr’:
persistent/cPersistence.c:1481:44: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
         snprintf(buf, sizeof(buf) - 1, "%llx", oid_value);
                                         ~~~^   ~~~~~~~~~
                                         %lx

<stdint.h> defines standard macros such as PRId64, PRIu64 and PRIx64 for
printing {u,}int64_t values, so let's use them.


  Commit: 19661a9eea60168d6fcf12df0b122a22a573a6a8
      https://github.com/zopefoundation/persistent/commit/19661a9eea60168d6fcf12df0b122a22a573a6a8
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Why does Microsoft even exist?


  Commit: 101d1eda55585d262ebe17b1146abd67e93d506b
      https://github.com/zopefoundation/persistent/commit/101d1eda55585d262ebe17b1146abd67e93d506b
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Oh, actually it was my mistake

PRIx64 is defined in <inttypes.h>, not <stdint.h>.

I hate C.


  Commit: 700d25cff063c539dc0af6ec5b1dc1cdd325d423
      https://github.com/zopefoundation/persistent/commit/700d25cff063c539dc0af6ec5b1dc1cdd325d423
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M .manylinux-install.sh
    M .travis.yml
    M CHANGES.rst
    M appveyor.yml
    M setup.py
    M tox.ini

  Log Message:
  -----------
  Drop Python 3.4 support


  Commit: 3e0f98d6bd44f15fb2f149d52f076fb3256a2ff4
      https://github.com/zopefoundation/persistent/commit/3e0f98d6bd44f15fb2f149d52f076fb3256a2ff4
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M .manylinux-install.sh
    M .travis.yml
    M CHANGES.rst
    M appveyor.yml
    M persistent/cPersistence.c
    M setup.py
    M tox.ini

  Log Message:
  -----------
  Merge pull request #111 from zopefoundation/fix-c-warning

Fix C compilation warning


  Commit: b12ffc5516b4aabc0e1898228eceb5068773cc39
      https://github.com/zopefoundation/persistent/commit/b12ffc5516b4aabc0e1898228eceb5068773cc39
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M CHANGES.rst
    M setup.py

  Log Message:
  -----------
  Preparing release 4.5.0


  Commit: 1b2ffc39685fea47fb4fb6e18bd90101f762e49d
      https://github.com/zopefoundation/persistent/commit/1b2ffc39685fea47fb4fb6e18bd90101f762e49d
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M CHANGES.rst
    M setup.py

  Log Message:
  -----------
  Back to development: 4.5.1


  Commit: 0dd333210384c40031bc6d11b1791ada95030d3e
      https://github.com/zopefoundation/persistent/commit/0dd333210384c40031bc6d11b1791ada95030d3e
  Author: Michael Howitz <mh at gocept.com>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M .manylinux-install.sh
    M CHANGES.rst
    M persistent/cPersistence.c
    M setup.py
    M tox.ini

  Log Message:
  -----------
  Merge branch 'master' into py34,py38

* master:
  Back to development: 4.5.1
  Preparing release 4.5.0
  Drop Python 3.4 support
  Oh, actually it was my mistake
  Why does Microsoft even exist?
  Fix C compilation warning

# Conflicts:
#	CHANGES.rst
#	setup.py
#	tox.ini


  Commit: 2b482ad7ef2c3f210090cf2aa193515198ddebe6
      https://github.com/zopefoundation/persistent/commit/2b482ad7ef2c3f210090cf2aa193515198ddebe6
  Author: Michael Howitz <mh at gocept.com>
  Date:   2019-05-15 (Wed, 15 May 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Test pure versions and docs in TravisCI.

Remove not working Terryfy config for Python 3.8.


Compare: https://github.com/zopefoundation/persistent/compare/3c4f5274aea6...2b482ad7ef2c


More information about the checkins mailing list