[Checkins] [zopefoundation/persistent] e16512: Python3: Stop using undocumented PyLong_AS_LONG.

Jason Madden noreply at github.com
Fri Feb 21 14:14:45 CET 2020


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/persistent
  Commit: e1651241793ea6ec24cfab4fa0b79853e5a3a374
      https://github.com/zopefoundation/persistent/commit/e1651241793ea6ec24cfab4fa0b79853e5a3a374
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2020-02-20 (Thu, 20 Feb 2020)

  Changed paths:
    M persistent/_compat.h

  Log Message:
  -----------
  Python3: Stop using undocumented PyLong_AS_LONG.

Fixes #125

Because it was just an alias for the documented API, there should be no repercussions. The exception (and the reason for this issue in the first place) is if something both includes 'cPersistence.h' and also defines their own INT_AS_LONG macro. If the definitions differ, the compiler might now emit a warning. I saw that in BTrees https://github.com/zopefoundation/BTrees/pull/122/files#diff-277c29c35c8feb60719e5ec94a3fe72e


  Commit: 66fe514f3dfff37227200cea40ec98371846a917
      https://github.com/zopefoundation/persistent/commit/66fe514f3dfff37227200cea40ec98371846a917
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M persistent/_compat.h

  Log Message:
  -----------
  Merge pull request #130 from zopefoundation/issue125

Python3: Stop using undocumented PyLong_AS_LONG.


Compare: https://github.com/zopefoundation/persistent/compare/1a02a9fb1145...66fe514f3dff


More information about the checkins mailing list