[Grok-dev] Re: martian.scan changed

Jan-Wijbrand Kolman janwijbrand at gmail.com
Mon Aug 20 08:15:31 EDT 2007

> > JW is on vacation, but we should let him speak about his use case.

I'm back now :-)

> Yes, indeed.
> >  I
> > *believe* his motivation to have grok *not* look in tests or ftests
> > was so that test-setup code that might subclass from a Grok class
> > wouldn't be grokked during the main program execution. You don't want
> > classes that are there purely for testing purposes (and that are
> > manually grokked) to be picked up while your application is running.


I'm not sure what the current status is for this issue. What I know is:

*) The current solution to have scan.py by default skip (f)tests
directories used to be implemented in grok, just before martian split
of. After the split, I re-implemented this "feature" on a martian
branch. This still needs to be merged with the martian trunk.

*) In face-to-face discussions with Martijn, we indeed concluded the
current solution (having scan just skip these directories) is not the
most generic solution, but it is a quick fix for a problem that needs
to be solved ASAP (if you ask me). In other words, whenever there's
someone with time for the "Better Solution", we can refactor to that.

What I can do know (I have a little bit of time to spare), is to merge
the skip test branch with the trunk. We then have at least a simple,
working solution. Would that be ok?

kind regards,
Jan-Wijbrand Kolman

More information about the Grok-dev mailing list