[Grok-dev] Re: a nice grok todo item for a beginner

Darryl Cousins darryl at darrylcousins.net.nz
Sat Mar 24 18:06:23 EDT 2007


On Sat, 2007-03-24 at 11:29 -0600, Philipp von Weitershausen wrote:
> * When you implemented this feature, you didn't run Grok's tests. 
> Therefore you didn't notice that you actually broke a functional test
> in 
> Grok. I fixed this for you now. In the future, always (ALWAYS, no 
> excuses) run the tests before checking in. Even if you're just fixing
> up 
> whitespace or getting rid of an unused import, it's always good to
> know 
> that your "fix" doesn't break something else.
> * Furthermore, you didn't WRITE tests for the new functionality. We 
> require tests (unit tests and/or functional tests) for every major 
> change (feature, bugfix, etc.). In this case you should write a 
> functional test that exercises the delete functionality. I did not
> write 
> that for you. Please do it soon. 

I have done so and I note your comments. Thanks.

Best regards,

More information about the Grok-dev mailing list