[Grok-dev] Re: Redux: Grok actions and grok.grok() cleanup
janwijbrand at gmail.com
Tue Oct 30 16:28:26 EDT 2007
Philipp von Weitershausen wrote:
> Martijn Faassen wrote:
>> On 10/30/07, Martijn Faassen <faassen at startifact.com> wrote:
>>> I just realized I made a stupid mistake in my testing and I didn't
>>> test with the right version of Grok at all. I now get some errors.
>> With Philipp's help, I've repaired the errors (the signature of 'grok'
>> in custom grokkers has changed) and the code appears to work again. :)
> Per Martijn's suggestion, I've documented these and other necessary
> upgrade steps in a doc/upgrade.txt document.
> Since neither Martijn nor I experienced any major problems, I'll go
> ahead with the merge now.
I was running a little behind on this topic - I did test the grok
actions branch quickly last week. Since my apps do have the occasional
custom grokkker I needed to change their code, obviously. But I got
things working rather easily.
I know this is not a thorough review/test, but I nevertheless wanted to
let you know I do not see big problems with this merge.
Great work Philipp! And thx to Godefroid for bootstrapping it!
More information about the Grok-dev