[Grok-dev] Re: Fields inner class support removed in branch

Luciano Ramalho luciano at ramalho.org
Fri Sep 14 18:08:07 EDT 2007

On 9/14/07, Martijn Faassen <faassen at startifact.com> wrote:
> I see some changes in grok/admin/objectinfo.py. Most are changing a
> 'return' into 'return None', which seems fine.
> The changes to AnnotationsTraverser seem more drastic though: it prints
> out "TRAVERSE" and some other stuff. I don't know where these came from,
> but I don't think we should merge that bit. Uli?

I did not touch that file (objectinfo.py), not consciously anyway.
I'll double-check it and report back.

> In formlib.py, you left the following comment unchanged:
>      # if we have a non-interface context,
>      # we're autogenerating them from any model-specific
>      # fields along with any schemas defined by the context
> I think we should remove the "model-specific fields" bit, right?

Sure, I'll change that.

> I'm happy to say this patch mostly removes code, so that's good. Thanks
> for doing this work. With those changes, +1 to a merge.

OK, as soon as I figure out the source of the objectinfo changes you mentioned.



More information about the Grok-dev mailing list