[Grok-dev] z3c.testsetup tests in Grok itself (Uli?)
uli at gnufix.de
Mon Apr 26 11:33:54 EDT 2010
Martijn Faassen wrote:
> Sylvain did most of the work, so he should get most of the credit. :)
> And yeah, that's pretty cool stuff; it makes the functional/browser
> testing footprint of Grok a lot smaller.
Thanks Sylvain! :-)
> >> There's also the general question about whether these tests should be
> >> retained within the Grok core itself; the tests itself claim that these
> >> are old and that there is better stuff in z3c.testsetup itself. That
> >> said, I'd like to *first* identify what change is causing these tests to
> >> break now, because that might be something we need to know about.
> > I am relatively sure, that missing z.a.testing caused the failures.
> > Overall I'm all for removing that pieces from grok. It's cleaner to use
> > z3c.testsetup directly and would be one place less to spot in
> > development. There is nothing you couldn't do with z3c.testsetup
> > directly with a couple of code-lines.
> Okay, I'll remove these tests from Grok, then, all right? Can I remove
> z3c.testsetup as a dependency of Grok itself too?
Sure, if you don't do it, I will :-)
The upper piece of grok.testing had to be removed as well, I think. Is
there some documentation to update somewhere?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://mail.zope.org/pipermail/grok-dev/attachments/20100426/4f928c59/attachment.bin
More information about the Grok-dev