[Zodb-checkins] CVS: Zope3/lib/python/Persistence/BTrees -BTreeModuleTemplate.c:1.1.2.17

Tim Peters tim@zope.com
Mon, 10 Jun 2002 10:05:38 -0400


[Tres Seaver]
> I started to send you a note about the whine, and then just decided to
> fix it myself.

A note would have been fine, but since the compiler I'm using doesn't
complain in these cases, you do have a better shot at knowing whether a
putative fix fixes.

> I even had in mind backporting the patch, but blew my stack on that.

S'OK:  it went on and off my stack in the wee hours (i.e., I backported it
already).

> Macros do make life interesting;  perhaps the sanest thing is just to
> remove unbracketed 'if' as a prophylactic for the "What do you *mean*
> indentation isn't significant?" bugs to which Python programmers would
> be especially prone.

In my own (private) code I use curlies everywhere they're allowed <wink>.
That's neither Guido's style nor Jim's, though, and I try to make code blend
in.  But I confess the

if ()
  conditional code indented two spaces from block start;

if ()
  {
    conditional code indented four spaces from block start;
  }

GNU style drives me plain nuts, and sometimes I've had to reindent functions
just to "see" what they're doing.