[Zodb-checkins] SVN: ZODB/branches/3.4/ referencesf(): Use %r instead of %s format in the error message, else

[Tim Peters]

Log message for revision 30609:
  referencesf():  Use %r instead of %s format in the error message, else
  the pickle shown is full of unprintable characters.
  

Changed:
  U   ZODB/branches/3.4/NEWS.txt
  U   ZODB/branches/3.4/src/ZODB/serialize.py

-=-
Modified: ZODB/branches/3.4/NEWS.txt
===================================================================
--- ZODB/branches/3.4/NEWS.txt	2005-06-02 21:10:15 UTC (rev 30608)
+++ ZODB/branches/3.4/NEWS.txt	2005-06-02 21:27:02 UTC (rev 30609)
@@ -39,7 +39,14 @@
   has its own copy, and the C code hadn't been compiled in ZODB since before
   ZODB 3.3.
 
+Error reporting
+---------------
 
+- In the unlikely event that ``referencesf()`` reports an unpickling error
+  (for example, a corrupt database can cause this), the message it
+  produces no longer contains unprintable characters.
+
+
 What's new in ZODB3 3.4b1?
 ==========================
 Release date: 19-May-2005

Modified: ZODB/branches/3.4/src/ZODB/serialize.py
===================================================================
--- ZODB/branches/3.4/src/ZODB/serialize.py	2005-06-02 21:10:15 UTC (rev 30608)
+++ ZODB/branches/3.4/src/ZODB/serialize.py	2005-06-02 21:27:02 UTC (rev 30609)
@@ -514,7 +514,7 @@
         u.persistent_load = []
         u.noload()
         if len(p) > f.tell():
-            raise ValueError, 'Error unpickling, %s' % p
+            raise ValueError, 'Error unpickling %r' % p
 
 
     # References may be: