[ZODB-Dev] importchecker and the zodb

Martijn Faassen faassen at infrae.com
Thu Feb 26 15:40:08 EST 2004


Christian Robottom Reis wrote:

>On Thu, Feb 26, 2004 at 02:12:12PM -0500, Jeremy Hylton wrote:
>  
>
>>>When I run it against Zope 3, I notice that the ZODB code seems to 
>>>contain quite a few unused imports as well. I've however refrained in 
>>>the past from removing these unused imports from ZODB code.
>>>      
>>>
>>I use pychecker every once in a while when I run the ZODB tests, and I
>>remove all the unused imports it finds.  So maybe your checker does a
>>better job of finding them.
>>    
>>
>
>It must. I ran it against a number of applications here and I found
>hundreds (literally) of unused imports that pychecker never complained
>  
>
>about. Looks like a great tool, Martijn.
>  
>

Thanks! Beware for false positives though; doctests relying on an import 
in the module, and eval of course, for instance. I also got a bug report 
where code assigned to an attribute of a module that wasn't found.

Mostly it seems to be accurate enough though.

Regards,

Martijn




More information about the ZODB-Dev mailing list