[ZODB-Dev] Re: [Zope-Checkins] CVS:ZODB3/ZODB/FileStorage -fspack.py:1.3

[Dieter Maurer]

Chris Withers wrote at 2004-1-21 09:35 +0000:
>Tim Peters wrote:
>
>> I'm really just trying to get you and Toby to agree on a compromise both can
>> live with.  I don't want to swallow exceptions, but I really don't have time
>> to argue about it now.
>
>Well, reading what Toby posted again, I'd be happy for DB.pack() to swallow the 
>exception as well, sorry :-S

I would not wait until "DB" but catch the exception immediately
in "FileStoragePacker.pack".

In my view, it is not an error (neither on the
"Storage" nor the "DB" level) when a pack does not result in
any new transaction being packed.
A log entry is sufficient to indicate this expensive no-op.

BTW: when the user executes packing interactively, he will
see that the database does not change size after packing.
If packing is performed in the background, then the exception
is ignored anyway (resulting in a log entry, but we can get this
easier).

-- 
Dieter