[ZODB-Dev] More exciting ZODB errors ;-)

Jeremy Hylton jeremy at alum.mit.edu
Wed Dec 14 13:38:50 EST 2005


On 12/14/05, Tim Peters <tim at zope.com> wrote:
> > I don't have a checkout of ZODB, so I can't check the svn blame.  Does it
> > say who wrote the code and what change it was related to?
>
> Congratulations on weaseling out of another one ;-)!

It was much harder to weasel out of them when I actually had commit privileges.

>  Turns out this all
> happened after your statutory blame period, as part of a large merge to fix
> ZClasses:
>
> <http://svn.zope.org/ZODB/branches/3.4/src/ZODB/Connection.py?rev=29891&view
> =rev>
>
> That introduced the "and not self._invalidated" clause.  We'll fix that one
> way or another (it doesn't make sense), but I'm pretty sure it's irrelevant
> to Chris's symptom (it stops an optimization rather than creates a problem).

Right.  It's certainly going to hurt the performance of ZODB in a
high-write situation, because it will always read the current revision
of an object, even when it needs a non-current revision.

Jeremy


More information about the ZODB-Dev mailing list