[ZODB-Dev] Re: [Checkins] SVN:
zope.component/trunk/src/zope/component/registry.py Correct
error in persistance-bbb logic spotted by Jacob Holm
Benji York
benji at zope.com
Thu Jul 24 13:55:56 EDT 2008
On Thu, Jul 24, 2008 at 1:44 PM, Wichert Akkerman <wichert at wiggy.net> wrote:
> Log message for revision 88796:
> Correct error in persistance-bbb logic spotted by Jacob Holm
It seems strange (and a bit frightening) that -- ostensibly -- the tests
pass either way the code reads. Is there a missing test here?
> Changed:
> U zope.component/trunk/src/zope/component/registry.py
>
> -=-
> Modified: zope.component/trunk/src/zope/component/registry.py
> ===================================================================
> --- zope.component/trunk/src/zope/component/registry.py 2008-07-24 17:32:08 UTC (rev 88795)
> +++ zope.component/trunk/src/zope/component/registry.py 2008-07-24 17:44:53 UTC (rev 88796)
> @@ -75,7 +75,7 @@
> if provided is None:
> provided = _getUtilityProvided(component)
>
> - if (self._utility_registrations.get((provided, name)[:2])
> + if (self._utility_registrations.get((provided, name))[:2]
> == (component, info)):
> # already registered
> return
--
Benji York
Senior Software Engineer
Zope Corporation
More information about the ZODB-Dev
mailing list