[ZODB-Dev] Blob savepoints leaving garbage?

[Jim Fulton]

On Fri, Jul 10, 2009 at 11:52 AM, Tres Seaver<tseaver at palladion.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Christian Theune wrote:
>> On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote:
>>> Hi,
>>>
>>> I think I didn't totally grasp the way that blob savepoints work correctly. At
>>> one of our installations we have lots of .spb files left around.
>>>
>>> Looking at the code I don't see where .spb files get cleaned up again on
>>> savepoint aborts.
>>
>> I reviewed the savepoint tests and see that they don't check for cleanup:
>> neither on rollback, nor on abort.
>>
>>> On the bushy branch I found that having the TmpStore create directory
>>> structures is probably a bad idea. I propose to have it create a directory
>>> `savepoints` in the temporary directory and create files called
>>> `oidrepr-tidrepr.spb`.
>>
>> I implemented this on the branch and it seems to work well. I find it easier
>> to inspect on the filesystem than having savepoint state being distributed
>> over the whole structure.
>
> Did a fix for the leaked saveepoint stuff ever get committed?

I just committed the fix to the trunk and the fix will be in 3.9.

>
>  https://bugs.launchpad.net/zodb/+bug/323067
>
> Can we safely remove anything under tmp/savepoints, assuming that we
> know there is not a transaction running?

Yes.

Jim

-- 
Jim Fulton