[ZODB-Dev] Some tests do not pass load's version parameter

Vincent Pelletier vincent at nexedi.com
Mon Dec 13 04:11:31 EST 2010


Hi.

Reading ZODB.interface, I realised the "version" parameter is defined as 
mandatory:

class IStorage(Interface):
   [...]
    def load(oid, version):

But some tests do not pass this parameter:

$ grep "\.load([^,]*)" *.py
BasicStorage.py:        tid3 = self._storage.load(oid)[1]
BasicStorage.py:        self.assert_(tid3 > 
self._storage.load('\0\0\0\0\0\0\0\xf3')[1])
BasicStorage.py:            tid4 = self._storage.load(oid)[1]
BasicStorage.py:            self.assert_(tid4 > 
self._storage.load('\0\0\0\0\0\0\0\xf4')[1])
[...]

I didn't review other matches, and my quick regex ignores word-wrapped lines.

I think either should be fixed, but I'm not sure which (I tend to think 
interface should be fixed).

Regards,
-- 
Vincent Pelletier


More information about the ZODB-Dev mailing list