[Zope-Checkins] CVS: Zope/lib/python/OFS - ObjectManager.py:1.164

Florent Guillaume cvs-admin at zope.org
Sun Nov 2 13:02:37 EST 2003


Update of /cvs-repository/Zope/lib/python/OFS
In directory cvs.zope.org:/tmp/cvs-serv17090/lib/python/OFS

Modified Files:
	ObjectManager.py 
Log Message:
ConflictError was swallowed in ObjectManager by manage_beforeDelete and
_delObject. This could break code expecting to do cleanups before
deletion.


=== Zope/lib/python/OFS/ObjectManager.py 1.163 => 1.164 ===
--- Zope/lib/python/OFS/ObjectManager.py:1.163	Tue Feb 11 16:06:28 2003
+++ Zope/lib/python/OFS/ObjectManager.py	Sun Nov  2 13:02:36 2003
@@ -28,6 +28,7 @@
 from Acquisition import aq_base
 from AccessControl.SecurityInfo import ClassSecurityInfo
 from webdav.Lockable import ResourceLockedError
+from ZODB.POSException import ConflictError
 from urllib import quote
 from cStringIO import StringIO
 import marshal
@@ -300,6 +301,8 @@
                     object.manage_beforeDelete(item, container)
             except BeforeDeleteException, ob:
                 raise
+            except ConflictError:
+                raise
             except:
                 LOG('Zope',ERROR,'manage_beforeDelete() threw',
                     error=sys.exc_info())
@@ -311,6 +314,8 @@
         try:
             object.manage_beforeDelete(object, self)
         except BeforeDeleteException, ob:
+            raise
+        except ConflictError:
             raise
         except:
             LOG('Zope',ERROR,'manage_beforeDelete() threw',




More information about the Zope-Checkins mailing list