[Zope-Checkins] SVN: Zope/trunk/ - ZSQLMethod.manage_main: Moved the error message that warns of a

Jens Vagelpohl jens at dataflake.org
Sun Oct 16 13:23:18 EDT 2005


Log message for revision 39475:
  - ZSQLMethod.manage_main: Moved the error message that warns of a
    non-existing or closed database connection next to the Connection ID
    dropdown and present it using red to increase its visibility.
  

Changed:
  U   Zope/trunk/doc/CHANGES.txt
  U   Zope/trunk/lib/python/Products/ZSQLMethods/dtml/edit.dtml

-=-
Modified: Zope/trunk/doc/CHANGES.txt
===================================================================
--- Zope/trunk/doc/CHANGES.txt	2005-10-16 17:23:01 UTC (rev 39474)
+++ Zope/trunk/doc/CHANGES.txt	2005-10-16 17:23:17 UTC (rev 39475)
@@ -6,14 +6,14 @@
 
   To-do
 
-   - Renable C permission roles by implementing recent Python
+   - Reenable C permission roles by implementing recent Python
      changes in C, brining the Python and C implementations back in
      sync.  See lib/python/AccessControl/PermissionRole.py.
 
    - Add cyclic-garbage collection support to C extension classes,
      especially to acquisition wrappers.
 
-   - Renable C Zope security policy by implementing recent Python
+   - Reenable C Zope security policy by implementing recent Python
      changes in C, bringing the Python and C implementations back in
      sync.  See lib/python/AccessControl/ZopeSecurityPolicy.py.
 
@@ -42,6 +42,12 @@
         line in fileobject: ..., as well as fileobject.next() and
         fileobject.xreadlines() ) Collector #1837
 
+    Other
+
+      - ZSQLMethod.manage_main: Moved the error message that warns of a
+        non-existing or closed database connection next to the Connection ID
+        dropdown and present it using red to increase its visibility.
+
   after Zope 2.8.1
 
       - The '@' character is now allowed in object ids (RFC 1738 allows it).

Modified: Zope/trunk/lib/python/Products/ZSQLMethods/dtml/edit.dtml
===================================================================
--- Zope/trunk/lib/python/Products/ZSQLMethods/dtml/edit.dtml	2005-10-16 17:23:01 UTC (rev 39474)
+++ Zope/trunk/lib/python/Products/ZSQLMethods/dtml/edit.dtml	2005-10-16 17:23:17 UTC (rev 39475)
@@ -2,16 +2,6 @@
 <dtml-var manage_tabs>
 
 <dtml-if SQLConnectionIDs>
-<dtml-if connectionIsValid>
-   <dtml-if connected><dtml-else>
-      <strong>Warning:</strong>
-      The database connection used by this method is currently not
-      open.
-   </dtml-if>
-<dtml-else>
-      <strong>Warning:</strong>
-      The database connection for this method cannot be found!
-</dtml-if>
 
 <form action="manage_edit" method="POST">
 <table cellpadding="2" cellspacing="0" width="100%" border="0">
@@ -42,6 +32,19 @@
                 &dtml-sequence-key;</option>
               </dtml-in>
     </select>
+    <dtml-if connectionIsValid>
+       <dtml-if connected><dtml-else>
+         <p style="{color:red;}">
+          <strong>Warning:</strong>
+          The database connection used by this method is closed.
+        </p>
+       </dtml-if>
+    <dtml-else>
+      <p style="{color:red;}">
+        <strong>Warning:</strong>
+        The database connection for this method cannot be found!
+      </p>
+    </dtml-if>
     </div>
     </td>
   </tr>



More information about the Zope-Checkins mailing list