[Zope-Checkins] SVN: Zope/branches/2.9/ SiteErrorLog only copied the unformatted traceback to the event.log,

Stefan H. Holek stefan at epy.co.at
Tue May 9 07:27:27 EDT 2006


Log message for revision 68063:
  SiteErrorLog only copied the unformatted traceback to the event.log,
  missing out on __traceback_supplement__.
  

Changed:
  U   Zope/branches/2.9/doc/CHANGES.txt
  U   Zope/branches/2.9/lib/python/Products/SiteErrorLog/SiteErrorLog.py

-=-
Modified: Zope/branches/2.9/doc/CHANGES.txt
===================================================================
--- Zope/branches/2.9/doc/CHANGES.txt	2006-05-09 11:24:22 UTC (rev 68062)
+++ Zope/branches/2.9/doc/CHANGES.txt	2006-05-09 11:27:26 UTC (rev 68063)
@@ -37,6 +37,9 @@
 
       - OFS.PropertyManager: Provided missing security declarations.
 
+      - Products.SiteErrorLog: SiteErrorLog only copied the unformatted
+        traceback to the event.log, missing out on __traceback_supplement__.
+
   Zope 2.9.2 (2006/03/27)
 
     Bugs fixed

Modified: Zope/branches/2.9/lib/python/Products/SiteErrorLog/SiteErrorLog.py
===================================================================
--- Zope/branches/2.9/lib/python/Products/SiteErrorLog/SiteErrorLog.py	2006-05-09 11:24:22 UTC (rev 68062)
+++ Zope/branches/2.9/lib/python/Products/SiteErrorLog/SiteErrorLog.py	2006-05-09 11:27:26 UTC (rev 68063)
@@ -213,18 +213,18 @@
                 LOG.error('Error while logging', exc_info=sys.exc_info())
             else:
                 if self.copy_to_zlog:
-                    self._do_copy_to_zlog(now,strtype,str(url),info)
+                    self._do_copy_to_zlog(now,strtype,str(url),tb_text)
                 return '%s/showEntry?id=%s' % (self.absolute_url(), entry_id)
         finally:
             info = None
 
-    def _do_copy_to_zlog(self,now,strtype,url,info):
+    def _do_copy_to_zlog(self,now,strtype,url,tb_text):
         when = _rate_restrict_pool.get(strtype,0)
         if now>when:
             next_when = max(when, now-_rate_restrict_burst*_rate_restrict_period)
             next_when += _rate_restrict_period
             _rate_restrict_pool[strtype] = next_when
-            LOG.error(str(url), exc_info=info)
+            LOG.error('%s\n%s' % (url, tb_text.rstrip()))
 
     security.declareProtected(use_error_logging, 'getProperties')
     def getProperties(self):



More information about the Zope-Checkins mailing list