[Zope-Checkins] SVN: Zope/branches/2.12/ Turn `UndoSupport.get_request_var_or_attr` helper into a private API.

Hanno Schlichting hannosch at hannosch.eu
Mon Dec 12 13:25:47 UTC 2011


Log message for revision 123753:
  Turn `UndoSupport.get_request_var_or_attr` helper into a private API.
  

Changed:
  U   Zope/branches/2.12/doc/CHANGES.rst
  U   Zope/branches/2.12/src/App/Undo.py
  U   Zope/branches/2.12/src/App/interfaces.py

-=-
Modified: Zope/branches/2.12/doc/CHANGES.rst
===================================================================
--- Zope/branches/2.12/doc/CHANGES.rst	2011-12-12 13:24:46 UTC (rev 123752)
+++ Zope/branches/2.12/doc/CHANGES.rst	2011-12-12 13:25:47 UTC (rev 123753)
@@ -8,6 +8,8 @@
 2.12.21 (unreleased)
 --------------------
 
+- Turn `UndoSupport.get_request_var_or_attr` helper into a private API.
+
 - Provide security declarations for `BTreeFolder2Base` class, instead of only
   for `BTreeFolder2` via the `OFS.Folder` mix-in.
 

Modified: Zope/branches/2.12/src/App/Undo.py
===================================================================
--- Zope/branches/2.12/src/App/Undo.py	2011-12-12 13:24:46 UTC (rev 123752)
+++ Zope/branches/2.12/src/App/Undo.py	2011-12-12 13:25:47 UTC (rev 123753)
@@ -50,7 +50,7 @@
         last_transaction=20,
         )
 
-    def get_request_var_or_attr(self, name, default):
+    def _get_request_var_or_attr(self, name, default):
         if hasattr(self, 'REQUEST'):
             REQUEST=self.REQUEST
             if REQUEST.has_key(name):
@@ -74,15 +74,15 @@
                               PrincipiaUndoBatchSize=None):
 
         if first_transaction is None:
-            first_transaction = self.get_request_var_or_attr(
+            first_transaction = self._get_request_var_or_attr(
                 'first_transaction', 0)
 
         if PrincipiaUndoBatchSize is None:
-            PrincipiaUndoBatchSize = self.get_request_var_or_attr(
+            PrincipiaUndoBatchSize = self._get_request_var_or_attr(
                 'PrincipiaUndoBatchSize', 20)
 
         if last_transaction is None:
-            last_transaction = self.get_request_var_or_attr(
+            last_transaction = self._get_request_var_or_attr(
                 'last_transaction',
                 first_transaction+PrincipiaUndoBatchSize)
 

Modified: Zope/branches/2.12/src/App/interfaces.py
===================================================================
--- Zope/branches/2.12/src/App/interfaces.py	2011-12-12 13:24:46 UTC (rev 123752)
+++ Zope/branches/2.12/src/App/interfaces.py	2011-12-12 13:25:47 UTC (rev 123753)
@@ -59,10 +59,6 @@
 
     manage_UndoForm = Attribute("""Manage Undo form""")
 
-    def get_request_var_or_attr(name, default):
-        """
-        """
-
     def undoable_transactions(first_transaction=None,
                               last_transaction=None,
                               PrincipiaUndoBatchSize=None):



More information about the Zope-Checkins mailing list