[Zope-CMF] [dev] delete members: related changes and updated proposal

J Cameron Cooper jccooper at jcameroncooper.com
Tue Sep 16 21:50:14 EDT 2003


>>While the idea that this method should delete the folders by default is 
>>fine and expected, it seems strange to have flags that default to true. 
>>If it's a "hidden" option, one should turn it on, rather than off, when 
>>over-riding. How about:
>>
>>def deleteMembers(member_ids, keep_memberareas=0,
>>                   keep_localroles=0):
>>    
>>
>-1.  Such a refactoring is a change to the contract, and will break any
>callers which were not using the defaulted parameter.  OTOH, if this is
>a new API, or a private method, then feel free. :)
>  
>
I whole-heartedly agree that it would be a bad bad thing to go flipping 
around defaults in a defined method.

But seeing how it doesn't exist yet...

          --jcc

-- 
"Code generators follow the 80/20 rule. They solve most of the problems, but not all of the problems. There are always features and edge cases that will need hand-coding. Even if code generation could build 100 percent of the application, there will still be an endless supply of boring meetings about feature design."
(http://www.devx.com/java/editorial/15511)





More information about the Zope-CMF mailing list