[Zope-CMF] CMF 2.2.0-alpha: getIcon

Hanno Schlichting hanno at hannosch.eu
Mon Nov 16 13:01:49 EST 2009


Hi.

On Mon, Nov 16, 2009 at 6:24 PM, yuppie <y.2009 at wcm-solutions.de> wrote:
> CMF 2.2.0-alpha has some getIcon changes based on what I proposed here:
> https://mail.zope.org/pipermail/zope-cmf/2009-January/028059.html
>
> Unfortunately the issue is more complicated than I thought and some
> things are now broken in CMF 2.2.0-alpha: The return values of getIcon()
> and icon() are not backwards compatible, breaking e.g. the ZMI icons if
> REQUEST['BASEPATH1'] exists.
>
> There are 4 ways to specify icons:

Oh dear :-(

> Proposal
> --------
>
> In CMF we always need the absolute URL. Since getIcon() and icon()
> already have a different meaning and something like
> getIcon(absolute=True) looks too complicated for the default, I propose
> to add a new method: getIconURL()
>
> getIcon() and icon() should get the same behavior as they had in CMF 2.1.

Sounds reasonable. I was hoping we could get away with a new method
but it seems I failed.

Hanno


More information about the Zope-CMF mailing list