[Zope-dev] Fw: [Exuserfolder-devel] Zope 2.5b1 release

[Paul Everitt]

Whew, that email (and the preceding one in the thread) is quite a=20
whopper.  In substance, amk raises some pretty serious issues that we=20
need to come to grips with very quickly.

I don't have enough information to respond right now, but trust that=20
we'll get a good response back today.

Neo-moderator note: if the discussion _does_ start over here, everyone=20
is advised to leave the anger at the door.  Problems like this can=20
usually be solved pretty easily by direct communication and open minds.

--Paul

Dario Lopez-K=E4sten wrote:

> I thought this might be intresting for discussion on zope-dev as well...
>=20
> /dario
>=20
> ----- Original Message -----
> From: "Andrew Kenneth Milton" <akm@theinternet.com.au>
> To: "Andrew Kenneth Milton" <akm@theinternet.com.au>
> Cc: <exuserfolder-devel@sourceforge.net>
> Sent: Thursday, November 29, 2001 8:45 AM
> Subject: Re: [Exuserfolder-devel] Zope 2.5b1 release
>=20
> It has been pointed out that perhaps the dripping sarcasm drowned out t=
he
> acutal points of the email, sorry I was particularly pissed off at how
> half-assed it all was.
>=20
> If you are writing a product that needs to create a user, you go look i=
n
> User.py and find out what the API since that tends to be the only place
> the API is documented.
>=20
> If you look at how UserFolder is implemented;
>=20
> a) The change to manage_* seems to be completely arbitrary, since we al=
ready
>    had _do* methods that meant you didn't have to call manage_users wit=
h
>    fake submit buttons. So what is the point of having manage_ ?
>=20
> b) manage_* methods usually indicate web callable methods, which these
> clearly
>    aren't (no docstring, no REQUEST parameter). In fact they don't retu=
rn a
> status
>    at all, so they seem to doubly useless.
>=20
> c) If it's an internal API for applications then the methods should pro=
bably
>    be protected by being prefixed with an _ to indicate they're not for
> calling
>    from the web or from within Documents/Templates.
>=20
> d) Even if you conformed to the API by calling e.g. manage_addUser() th=
is
>    seemed to be incorrect, since it didn't do things like encrypt the
> password.
>    This meant you would have to either a) encrypt the password yourself
>    (*very bad for XUF*), or b) call _addUser() which is not part of a
> defined
>    API but looks like it should be (i.e. manage_addUser and _addUser se=
em to
>    be reversed in functionality).
>=20
>    ii) This is compounded by the fact you would have to query the UserF=
older
>        itself to find out if you should be encrypting passwords (what n=
o
>        UserFolder capability API?).
>=20
> e) s/_do/manage_/ doesn't constitute a new API. It's just the old one w=
ith
> the
>    names changed.
>=20
> f) We've done a lot of work to make a flexible UF product that is I18Ne=
d
>    (well -able), and they still use the value of the submit button. I w=
ould
> have
>    expected to see an alternative manage_users called from the ZMI that
>    behaved much better, with manage_users calls raising warnings.
>=20
> g) Someone got paid to do it, and that just pisses me off, given the qu=
ality
>    of the stuff we release for free (and I'm still looking for a job bt=
w
> d8).
>    We're not perfect, the 0.10.1 release shows that, but, at least we
>    spent more than three minutes including thinking time on it, and I a=
t
> least
>    try not to change things just for the sake of it.
>=20
> Anyway. In case you were wondering what the previous email meant, there=
's
> the
> actual meaning d8)
>=20
> --
> Totally Holistic Enterprises Internet|                      | Andrew Mi=
lton
> The Internet (Aust) Pty Ltd          |                      |
> ACN: 082 081 472 ABN: 83 082 081 472 |  M:+61 416 022 411   | Carpe Dae=
mon
> PO Box 837 Indooroopilly QLD 4068    |akm@theinternet.com.au|
>=20
> _______________________________________________
> Exuserfolder-devel mailing list
> Exuserfolder-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/exuserfolder-devel
>=20
>=20
>=20
> _______________________________________________
> Zope-Dev maillist  -  Zope-Dev@zope.org
> http://lists.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -=20
>  http://lists.zope.org/mailman/listinfo/zope-announce
>  http://lists.zope.org/mailman/listinfo/zope )
>=20