[Zope-dev] Re: SVN: Zope/trunk/ Moved two implements declarations from Five into the proper classes.

Tres Seaver tseaver at palladion.com
Sun Oct 21 12:15:20 EDT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philipp von Weitershausen wrote:
> Hanno Schlichting wrote:
>> Log message for revision 80945:
>>   Moved two implements declarations from Five into the proper classes.
> 
> I object to this change. HTTPRequest does not really fulfil the 
> IBrowserRequest interface, and ObjectManager isn't a real IContainer 
> either. I understand that somebody made a mistake when they declared 
> them as such in the early days of Five. This is the reason we can't take 
> it back. But, at least as a sign of the fact that they're not (yet) the 
> real deal, this declaration has remained in ZCML.
> 
> A sensible step forward would be to make HTTPRequest a full 
> IBrowserRequest (we're getting there).

I'm note sure we can get there:  the 'traverse()' method, for instance,
has incompatible semantics.  We might be better off making an adapter,
and tweaking the Z3 publisher to adapt the request before looking up
things against it.

> As for ObjectManager, I think 
> IContainer implies a couple of semantics (such as unicode names, the 
> sending of events, etc.) that we should look closer at before deciding.

Don't konw about that one.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHG3sY+gerLs4ltQ4RAj6AAKC/6HKHN4iTq0gZSro1BMg3xKpi+ACeOItY
zaR5FrBy/C1MGRc8TKJL6IA=
=5l3C
-----END PGP SIGNATURE-----



More information about the Zope-Dev mailing list