[Zope3-checkins] SVN: Zope3/trunk/src/zope/app/pluggableauth/__init__.py resolved some XXXs through comments or documentation

Jim Fulton jim at zope.com
Wed Jul 7 14:34:31 EDT 2004


Log message for revision 26176:
resolved some XXXs through comments or documentation



-=-
Modified: Zope3/trunk/src/zope/app/pluggableauth/__init__.py
===================================================================
--- Zope3/trunk/src/zope/app/pluggableauth/__init__.py	2004-07-07 18:34:24 UTC (rev 26175)
+++ Zope3/trunk/src/zope/app/pluggableauth/__init__.py	2004-07-07 18:34:31 UTC (rev 26176)
@@ -90,8 +90,9 @@
         return None
 
     def unauthenticatedPrincipal(self):
-        """ See IAuthenticationService. """
-        return None # XXX Do we need to implement or use another?
+        # It's safe to assume that the global auth service will
+        # provide an unauthenticated principal, so we won't bother.
+        return None
 
     def unauthorized(self, id, request):
         """ See IAuthenticationService. """
@@ -570,6 +571,14 @@
         return test_password == self.password
 
 class PrincipalAuthenticationView:
+    """Simple basic authentication view
+
+    This only handles requests which have basic auth credentials
+    in them currently (ILoginPassword-based requests).
+    If you want a different policy, you'll need to write and register
+    a different view, replacing this one.
+    
+    """
     implements(IViewFactory)
 
     def __init__(self, context, request):
@@ -577,10 +586,6 @@
         self.request = request
 
     def authenticate(self):
-        # XXX we only handle requests which have basic auth credentials
-        # in them currently (ILoginPassword-based requests)
-        # If you want a different policy, you'll need to write and register
-        # a different view, replacing this one.
         a = ILoginPassword(self.request, None)
         if a is None:
             return



More information about the Zope3-Checkins mailing list