[Zope3-checkins] SVN: Zope3/branches/3.2/ Fixed issue 716 'make check throws exception' by backporting Jim's fix from branches/3.3

Michael Howitz mh+zope at gocept.com
Fri Sep 29 04:05:29 EDT 2006


Log message for revision 70438:
  Fixed issue 716 'make check throws exception' by backporting Jim's fix from branches/3.3

Changed:
  U   Zope3/branches/3.2/doc/CHANGES.txt
  U   Zope3/branches/3.2/releases/Zope/test.py

-=-
Modified: Zope3/branches/3.2/doc/CHANGES.txt
===================================================================
--- Zope3/branches/3.2/doc/CHANGES.txt	2006-09-29 07:25:44 UTC (rev 70437)
+++ Zope3/branches/3.2/doc/CHANGES.txt	2006-09-29 08:05:26 UTC (rev 70438)
@@ -104,7 +104,11 @@
         UnicodeEncodeError when uses non-ascii unicode string in
         template.
 
+      - Fixed issue 716, make check no longer throws ValueError "I/O
+        operation on closed file" after all tests have run. Backport
+        of Jim's workaround in 3.3.
 
+
   Zope 3.2.1 (2006/03/26)
 
     Bug fixes

Modified: Zope3/branches/3.2/releases/Zope/test.py
===================================================================
--- Zope3/branches/3.2/releases/Zope/test.py	2006-09-29 07:25:44 UTC (rev 70437)
+++ Zope3/branches/3.2/releases/Zope/test.py	2006-09-29 08:05:26 UTC (rev 70438)
@@ -45,8 +45,16 @@
 
 result = testrunner.run(defaults)
 
+# Note, the logging system has bugs, fixed in Python 2.5 that cause spurious
+# errors on exit.  We'll execute a fairly voilent suicide to try to avoid
+# these.  Given that this is just a test runner, this should be OK.
+
 # Avoid spurious error during exit. Some thing is trying to log
 # something after the files used by the logger have been closed.
 logging.disable(999999999)
 
-sys.exit(result)
+# Because we're about to use os._exit, we flush output so we don't miss any.
+sys.stdout.flush()
+sys.stderr.flush()
+
+os._exit(result)



More information about the Zope3-Checkins mailing list