[Zope3-dev] Re: [Zope-Checkins] CVS: Zope3/lib/python/Persistence - cPersistence.c:1.1.2.12

Guido van Rossum guido@python.org
Wed, 06 Mar 2002 17:29:23 -0500


> > Fix typo in assert.  (Caught by Fred.)
> > 
> > === Zope3/lib/python/Persistence/cPersistence.c 1.1.2.11 => 1.1.2.12 ===
> >         goto err;
> >      PyTuple_SET_ITEM(implements, 0, iface);
> > -    assert(type->typ_dict != NULL);
> > +    assert(type->tp_dict != NULL);
> >      r = PyDict_SetItemString(type->tp_dict, "__implements__", implements);
> >   err:
> >      Py_XDECREF(mod);
> 
> Wasn't it caught by a test? If not, there probably should have been a test :-S

This would mean another nightly test run with all C code (Python and
extensions) compiled in debug mode.  I'm all for it; it's easy to
forget that debug mode even exists...

--Guido van Rossum (home page: http://www.python.org/~guido/)