[Zope3-dev] Re: CVS: Zope3/src/zope/app/browser/skins/rotterdam - editingwidgets.py:1.4.24.2

[Tres Seaver]

Garrett Smith wrote:
> Update of /cvs-repository/Zope3/src/zope/app/browser/skins/rotterdam
> In directory cvs.zope.org:/tmp/cvs-serv2048/src/zope/app/browser/skins/rotterdam
> 
> Modified Files:
>       Tag: ozzope-widgets-branch
> 	editingwidgets.py 
> Log Message:
> 
> Trivial whitespace fix.
> 
> 
> === Zope3/src/zope/app/browser/skins/rotterdam/editingwidgets.py 1.4.24.1 => 1.4.24.2 ===
> --- Zope3/src/zope/app/browser/skins/rotterdam/editingwidgets.py:1.4.24.1	Sat Feb  7 23:36:11 2004
> +++ Zope3/src/zope/app/browser/skins/rotterdam/editingwidgets.py	Sat Feb  7 23:57:53 2004
> @@ -27,7 +27,7 @@
>      width = 60
>      height = 15
>      extra=""
> -    style="width: 98%; font-family: monospace;"
> +    style="width: 98%; font-family: monospace;".
>      rowTemplate = ViewPageTemplateFile("simpleeditingrow.pt")
>      rowFragment = ViewPageTemplateFile("simpleeditingrowfragment.pt")


Two things jump out at me:

   - That line isn't valid Python;  ergo, we must not have any unit
     tests for this module.

   - What in the name of separation-of-concerns are we doing adding
     inline styles, and in Python code?

Tres.
-- 
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com