[Zope3-dev] Re: Problem with zope.app.security._protections for tests

[Philipp von Weitershausen]

Fred Drake wrote:
> On 8/8/05, Philipp von Weitershausen <philipp at weitershausen.de> wrote:
> 
>>For compatability reasons, zope.app.security._protections and the
>>protect() function inside (though empty) should probably still exist for
>>at least another release because people might be using it in their own
>>tests (even though it's not public API). A deprecation warning could
> 
> 
> I disagree that we should be worried about people using that function
> directly; we've been much better in separating public API and
> implmentation detail in Zope 3.  Anything in a module with a name
> starting with an underscore is fair game.
> 
> I would, however, be more concerned about things that happen as a side
> effect of importing a package.  That's pretty magical and is not
> something many are likely to be watching out for.  I'm not suggesting
> that it's sufficient to require us to keep the behavior around; this
> is still an implementation detail within the zope.app hierarchy IMO.

In general I agree, but I was concerned about people using this
particular underscore function because it was their only way to get the
protections right in tests. This might have not worked anyway in which
case we can scrap it.

Either way, I don't feel strongly about this. Go ahead and remove the
sucker :).

Philipp