[Zope3-dev] RFC: should z.a.c.attribute.AttributeIndex index None values?

[Christian Theune]

Gary Poster wrote:
> On Nov 17, 2006, at 11:13 AM, Adam Groszer wrote:
>>
>> Two more questions remain open, but I think they are easy to answer.
>>
>> In case the field is callable but the method to be called is None
> 
> Yes, remove from index.

Same behaviour as for a None value, so remove from index as Gary said.

> I think the exception should be raised.  What to do here is a policy  
> decision that shouldn't be controlled at the index level IMO.   
> Generally I'd prefer a transaction abort, a system exception, and a  
> log entry, for instance.  When that's not acceptable, it's usually  
> within a part of a transaction that I again can control with a  
> savepoint, so that I revert to before the change that caused the  
> reindex, log the error, and proceed.

Yes please. Fail early and explicitly.


-- 
gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany
www.gocept.com - ct at gocept.com - phone +49 345 122 9889 7 -
fax +49 345 122 9889 1 - zope and plone consulting and development


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://mail.zope.org/pipermail/zope3-dev/attachments/20061117/63ab4fae/signature-0001.bin