[Checkins] SVN: zc.buildout/trunk/ merged the allow-hosts option
Tarek Ziadé
ziade.tarek at gmail.com
Wed Aug 13 12:37:55 EDT 2008
On Fri, Jul 11, 2008 at 3:35 PM, Philipp von Weitershausen <
philipp at weitershausen.de> wrote:
> Tarek Ziade wrote:
>
>> Log message for revision 87237:
>> merged the allow-hosts option
>>
>> Changed:
>> U zc.buildout/trunk/CHANGES.txt
>> A zc.buildout/trunk/src/zc/buildout/allowhosts.txt
>> U zc.buildout/trunk/src/zc/buildout/buildout.py
>> U zc.buildout/trunk/src/zc/buildout/buildout.txt
>> U zc.buildout/trunk/src/zc/buildout/easy_install.py
>> U zc.buildout/trunk/src/zc/buildout/tests.py
>> U zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py
>>
>> -=-
>> Modified: zc.buildout/trunk/CHANGES.txt
>> ===================================================================
>> --- zc.buildout/trunk/CHANGES.txt 2008-06-07 22:08:05 UTC (rev
>> 87236)
>> +++ zc.buildout/trunk/CHANGES.txt 2008-06-07 23:16:44 UTC (rev
>> 87237)
>> @@ -7,6 +7,8 @@
>> 1.0.4 (unreleased)
>> ==================
>> +- Added the `allow-hosts` option (tarek)
>> +
>>
> ...
>
>> Modified: zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py
>> ===================================================================
>> --- zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py 2008-06-07
>> 22:08:05 UTC (rev 87236)
>> +++ zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py 2008-06-07
>> 23:16:44 UTC (rev 87237)
>> @@ -39,6 +39,11 @@
>> options['index'] = index
>> self.index = index
>>
>>
> ...
>
>> @@ -78,6 +83,7 @@
>> always_unzip=options.get('unzip') == 'true',
>> path=[options['develop-eggs-directory']],
>> newest=self.buildout['buildout'].get('newest') == 'true',
>> + allow_hosts=self.allow_hosts
>> )
>>
>
> Tarek,
>
> you added the allow_hosts option to zc.buildout and made zc.recipe.egg use
> it. The problem with that is that they're independent eggs and could be
> upgraded independently from each other. In this case, if you got the newer
> zc.recipe.egg but still an older zc.buildout, things would break. It's
> therefore necessary to declare in zc.recipe.egg that it needs *at least*
> zc.buildout 1.0.6 or whatever the version was that contained the allow_hosts
> option first. In other words, zc.recipe.egg's dependency should have stated
>
> zc.buildout>=1.0.6
Good catch, I'll change that
Thx
>
>
> I wonder why zc.recipe.egg is actually a part of the zc.buildout tree.
> Woudln't it be easier to just have it as a top-level project in svn?
>
+1 this is annoying,
Tarek
--
Tarek Ziadé | Association AfPy | www.afpy.org
Blog FR | http://programmation-python.org
Blog EN | http://tarekziade.wordpress.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.zope.org/pipermail/checkins/attachments/20080813/5e396d2c/attachment.html
More information about the Checkins
mailing list