[Checkins] SVN: Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py Avoid intermediate list creation in catalog.delColumn

Hano Schlichting cvs-admin at zope.org
Sat Apr 7 11:49:19 UTC 2012


Log message for revision 125060:
  Avoid intermediate list creation in catalog.delColumn
  

Changed:
  U   Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py

-=-
Modified: Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py
===================================================================
--- Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py	2012-04-07 11:42:49 UTC (rev 125059)
+++ Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py	2012-04-07 11:49:15 UTC (rev 125060)
@@ -213,10 +213,11 @@
         self.updateBrains()
 
         # remove the column value from each record
-        for key, value in self.data.items():
+        _next_index = _index + 1
+        for key, value in self.data.iteritems():
             rec = list(value)
             del rec[_index]
-            self.data[key] = tuple(rec)
+            self.data[key] = value[:_index] + value[_next_index:]
 
     def addIndex(self, name, index_type):
         """Create a new index, given a name and a index_type.



More information about the checkins mailing list