[Grok-dev] contentprovider component

Christian Klinger cklinger at novareto.de
Thu Jun 23 09:16:51 EDT 2011


Hi JW,

thanks for your work. The implementation looks fine. But
it the ftests/contentprovider.py it seems to me that there
is more code in it that needed. Maybe you can have a quick look on
this test again.

It seems you want to show some layer integration. But i can't see
the test for it.

HTH
Christian

> Hi,
>
> On 6/1/11 16:58 , Sylvain Viollon wrote:
>> On Wed, 01 Jun 2011 16:06:22 +0200
>> Jan-Wijbrand Kolman<janwijbrand at gmail.com>  wrote:
>>
>>> On 6/1/11 14:23 , Sylvain Viollon wrote:
>>>> On Wed, 01 Jun 2011 11:58:06 +0200
>>>> Jan-Wijbrand Kolman<janwijbrand at gmail.com>  wrote:
>>>>> Since the component is very much view-like, I'd like to add this
>>>>> component to grokcore.view. The components in grokcore.viewlet
>>>>> could then be based on this generalization.
>>>>>
>>>>> Any thoughts on this is highly appreciated!
>>>>
>>>>    In Silva I do already have such a component. It is the same than a
>>>>    viewlet manager in fact, at the exception it is referred by
>>>> 'provider' in the template namespace instead of
>>>> 'viewletmanager' (which is kind of long).
>>>
>>> So, would you like to have that component in grokcore.view instead? I
>>> think I would, so I can make it. Would it be useful for you too?
>>
>>    I think my answer said implicitly yes :)
>
> I finally got around doing this. It is here:
>
>    http://svn.zope.org/grokcore.view/branches/jw-contentproviders/
>
> I hope someone has a moment of time to give it a quick look.
>
> Sylvain, can I ask you explicitly to look at how the content provider
> grokker configuration is triggered from the meta.zcml and
> meta-minimal.zcml? And if I did The Right Thing to make the content
> provider useful in a five.grok context?
>
> BTW, I tried to incorporate the ContentProvider component into
> grokcore.viewlet - as ViewletManager and Viewlets are basically content
> providers too - but I found myself adding all kinds of special cases. So
> I decided for now not to do this.
>
> regards, jw




More information about the Grok-dev mailing list