[ZODB-Dev] Includes patch: [johan@gnome.org: zodb3 trunk patch]

[Tim Peters]

[Christian Robottom Reis]
>     We're working on some IndexedCatalog changes, and apparently a
> header we need is not being installed. Tim, can you take a look and
> commit this if it makes sense to you (and let me know if not)?
>
> Thanks!
>
> ----- Forwarded message from Johan Dahlin <johan at gnome.org> -----
>
> Subject: zodb3 trunk patch
> From: Johan Dahlin <johan at gnome.org>
> Reply-To: johan at gnome.org
> To: Christian Robottom Reis <kiko at async.com.br>
> Date: Fri, 05 Nov 2004 01:00:02 +0100
> X-Spambayes-Classification: ham; 0.00
>
> This patch is needed to subclass objects of cPersistence. ring.h was
> introduced sometime ago, but it was not added correctly to the build
> system. The following patch fixes it.
>
>
> -- Johan Dahlin <johan at gnome.org>
>
> Index: setup.py
> ===================================================================
> --- setup.py	(revision 28340)
> +++ setup.py	(working copy)
> @@ -237,7 +237,8 @@
>        packages = packages,
>        package_dir = {'': 'src'},
>        ext_modules = exts,
> -      headers = ['src/persistent/cPersistence.h'],
> +      headers = ['src/persistent/cPersistence.h', +
>                   "src/persistent/ring.h"],
>        license = "ZPL 2.1",
>        platforms = ["any"],
>        description = doclines[0],

I'm not exactly sure which version of ZODB you're talking about here, but
figure it must be 3.3.  If so, ZODB's setup.py is no longer used when
building ZODB releases -- that's all done with zpkg now, and zpkg has its
own maze of config files (the 23 ALLUPPER.cfg files you'll find scattered
around a 3.3 checkout).

So, sure, I'll add the patch, but it won't make any difference <wink>.  Fred
& I can figure out how to fix this in the context of standalone ZODB
releases.

But I'm not sure that's what you're talking about either:  are you using a
ZODB release on its own, or are you using the ZODB that comes packaged with
a Zope release?  If the latter, I'm afraid I don't have any idea how Zope
2.8 releases are built now.  Looking at a Zope trunk checkout, it doesn't
appear to use zpkg (the only .cfg files it has were inherited from ZODB
3.3), so I suppose it's using its own setup.py -- oops, looks like it uses a
whole lot of files named setup.py.  Ah, I give up for tonight ...