[ZODB-Dev] Weird errors with Zope 2.7.7

[Dieter Maurer]

Chris Withers wrote at 2005-10-21 15:28 +0100:
> ...
>Do you mind if I apply the following patch to the ZODB trunk?
>
>Index: Connection.py
>===================================================================
>--- Connection.py       (revision 39510)
>+++ Connection.py       (working copy)
>@@ -725,7 +725,7 @@
>          if self._opened is None:
>              msg = ("Shouldn't load state for %s "
>                     "when the connection is closed" % oid_repr(oid))
>-            self._log.error(msg)
>+            self._log.error(msg,exc_info=True)
>              raise ConnectionStateError(msg)

I mind -- the change is stupid:

  Because you are not in an exception handler, "exc_info=True"
  cannot provide meaningful information -- there is no
  exception that can be presented...

>
>          try:
>@@ -734,7 +734,7 @@
>              raise
>          except:
>              self._log.error("Couldn't load state for %s", oid_repr(oid),
>-                            exc_info=sys.exc_info())
>+                            exc_info=True)

I do not mind this change.


-- 
Dieter