[Zope3-dev] Re: Database Adapter Collection Checkins

Christian Theune ct@gocept.com
Thu, 12 Dec 2002 15:40:29 +0100


--/Uq4LBwYP4y1W6pO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Stephan Richter <stephan.richter@tufts.edu> [021212 14:54]:
> On Thursday 12 December 2002 08:24, Christian Theune wrote:
> > initial checkin for the "database adapter collection"
> >
> > those are initial drafts. The mysql adapter is tested and able to conne=
ct
> > and query as well as the sapdb. Postgres has already been there.
> >
> > There will be a lot of issues with converting custom data types into
> > the zopish ones (see BLOB/CLOB...).
> >
> > The other database adapters aren't tested anyway, but probably work,
> > as it has mostly been an "edit and replace" work.
> >
> > (Is that a sign of refactoring?)
>=20
>=20
> Hi Christian,
>=20
> thanks for this great work! I hope people check this out and test the cod=
e.=20
>=20
> BTW, did you forget to checkin tests? I think we should write a set of te=
sts=20
> (including for PostGreSQL) that connects to the DB for real. This way peo=
ple=20
> can test the Adapter by simply running its tests...

Yes. Poorly I didn't forgot to check the tests in, but to write them.
Jim was looking for the modules for refactoring, so I checked them in
without tests.

I don't think that connecting to a real database within a test would be
apprioriate. I believe Steve would regard that as a functional test.
Which is not, what unit tests are.

--=20
Christian Theune - ct@gocept.com
gocept gmbh & co.kg - schalaunische strasse 6 - 06366 koethen/anhalt
tel.+49 3641 511586 - fax.+49 3496 3099118 - mob. +49 179 7808366

reduce(lambda x,y:x+y,[chr(ord(x)^42) for x in 'zS^BED\nX_FOY\x0b'])

--/Uq4LBwYP4y1W6pO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE9+J/ddUt9X/gknwIRAqkRAJ0XQiLC3w0yTZRwyOr0Gzb0qX+qdQCgzcxB
JLHRCj6Fi585fzhAHTrXmzo=
=kcw1
-----END PGP SIGNATURE-----

--/Uq4LBwYP4y1W6pO--