[Zope3-dev] RE: [Zope3-checkins] SVN: Zope3/trunk/src/ZConfig/datatypes.py Removed special handling of default server on Windows. Added XXX in the hope someone will take a closer look at this. Corresponds to issue 383.

[Garrett Smith]

Ah, crap! Sorry about that. Darnit...I forgot to commit the test fixes.

In any event, I'll back out the ZConfig changes and move the mods into
the zope app server.

 -- Garrett

Tim Peters wrote:
> Removed special handling of default server on Windows. Added XXX in
> the hope someone will take a closer look at this. Corresponds to
> issue 383. 
> 
> 
> [Garrett Smith]
>> Log message for revision 29484:
>>  Removed special handling of default server on Windows. Added XXX in
>> the hope someone will take a closer look at this. Corresponds to
>> issue 383. 
>> 
>> Changed:
>>  U   Zope3/trunk/src/ZConfig/datatypes.py
> 
> Two things here:
> 
> 1. Zope3 doesn't "own" ZConfig -- ZConfig is an external module that
>    gets stitched in to Zope3, from time to time.  So ZConfig checkins
> shouldn't be done
>    from Zope3 (they should be done from a ZConfig checkout).
> 
> 2. I suspect this accounts for 3 new Zope3 test failures, on Windows
> XP: 
> 
> FAIL: test_commandline_overrides
> (ZEO.tests.testZEOOptions.TestZEOOptions) 
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "C:\Code\24\lib\unittest.py", line 260, in run
>     testMethod()
>   File "C:\Code\Zope3\src\ZEO\tests\testZEOOptions.py", line 95, in
> test_commandline_overrides
>     self.assertEqual(options.address, (DEFAULT_HOSTNAME, 6666))
>   File "C:\Code\24\lib\unittest.py", line 333, in failUnlessEqual
>     raise self.failureException, \
> AssertionError: ('', 6666) != ('localhost', 6666)
> 
> ======================================================================
> FAIL: test_defaults_with_schema
> (ZEO.tests.testZEOOptions.TestZEOOptions) 
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "C:\Code\24\lib\unittest.py", line 260, in run
>     testMethod()
>   File "C:\Code\Zope3\src\ZEO\tests\testZEOOptions.py", line 69, in
> test_defaults_with_schema
>     self.assertEqual(options.address, (DEFAULT_HOSTNAME, 5555))
>   File "C:\Code\24\lib\unittest.py", line 333, in failUnlessEqual
>     raise self.failureException, \
> AssertionError: ('', 5555) != ('localhost', 5555)
> 
> ======================================================================
> FAIL: test_defaults_without_schema
> (ZEO.tests.testZEOOptions.TestZEOOptions) 
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "C:\Code\24\lib\unittest.py", line 260, in run
>     testMethod()
>   File "C:\Code\Zope3\src\ZEO\tests\testZEOOptions.py", line 81, in
> test_defaults_without_schema
>     self.assertEqual(options.address, (DEFAULT_HOSTNAME, 5555))
>   File "C:\Code\24\lib\unittest.py", line 333, in failUnlessEqual
>     raise self.failureException, \
> AssertionError: ('', 5555) != ('localhost', 5555)