[Zope3-dev] Re: [Checkins] SVN: zope.app.form/trunk/src/zope/app/form/browser/te FileWidget tries to be smarter about not deleting the currently stored content when the user did not upload a new file.

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian Zagrodnick wrote:
> On 2007-06-27 16:13:06 +0200, Gary Poster <gary at zope.com> said:
> 
>>> newvalue is not formfield? To me this does not make much sense. Why  
>>> would I return self.context to indicate the value has not changed?
>> As the comment says, looks like form_field is being used as a  
>> marker--.get should (hopefully) never return form_field, which is  
>> precisely the point: that way, if get returns form_field, that means  
>> that there is not a new value of any sort.
> 
> Geeh. I'm so blind. :(

That is actually why I am against the practice of using "real" objects
as markers, instead of artificial ones with obvious names:  it makes the
reader stop, and breaks the flow.  Too clever by half, as it were.


Trse.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGgqbq+gerLs4ltQ4RAj+BAJ9dmoFi6x6wJqa/2oYxpkv+0m6AYwCeO3g2
5dZZpJIeW3ayN3yH96qnotA=
=eLd6
-----END PGP SIGNATURE-----