[Zope3-dev] Re: [Zope3-checkins] CVS: Zope3/lib/python/Zope/App/OFS/Services/SmtpService/Views - __init__.py:1.1 configure.zcml:1.1

[Florent Guillaume]

Speaking of SMTP, I'm not too happy about the implementation just
checked in. It's not very clean, there are no docstrings, it won't
support Unicode strings and encode them as needed, it doesn't use string
methods as Kapil noticed, it doesn't use isinstance, the interface is
ISMTPService whereas the module is SmtpService, there are no unit tests,
even $Id: doesn't have a closing $...

Ok, ok, I'm whining and not writing that code, but still it had to be
said.

Florent


Stephan Richter  <stephan.richter@tufts.edu> wrote:
> BTW, in an old revision (Jim will know where to look) there is already code
> for a complete SMTP and POP3 Server. You might want to make use of the SMTP
> server code, so that Windows users do not have to provide their own server or
> so.
> 
> Also, in my opinion that makes Zope 3 much cooler. (I can see Windows people
> just using Zope for its SMTP capabilities, as there is no other good free one
> out there, except shicks! from which I derived my original code. Gerson, the
> author of shicks!, since then modularized shicks! a lot, so that we can just
> use his Spam detection code now.
> 
> I really, really think an SMTP server is important, if Zope wants to grow
> 10x...also think of Mailman 3... We need to get away of just thinking about
> HTTP and friends...
> 
> Here the link to the CVS entries:
> http://cvs.zope.org/Zope3/lib/python/Zope/Server/SMTP/Attic/
> 
> shicks! site:
> http://p-nand-q.com/shicks.htm
> 
> Regards,
> Stephan
-- 
Florent Guillaume, Nuxeo (Paris, France)
+33 1 40 33 79 87  http://nuxeo.com  mailto:fg@nuxeo.com