[Zope3-dev] SequenceWidget and issue 293

[Jim Fulton]

Derrick Hudson wrote:
> I have been working on my solution to Collector issue 293.  I created
> the tests and all tests pass now.  However, before I commit my changes
> I want to understand the motivation behind the changes that caused the
> problem.
> 
> 'svn blame' reports that the __init__ signature for SequenceWidget was
> last modified in r13834 (early May of 2004).  It seems that the
> 'value_type' argument was meant for something, however in more recent
> revisions it was ignored and is the source of the CustomWidgetFactory
> problem.

It was ignored in that revision too.  I suspect that the author added it,
intending to use it for something and then changed their mind.

> Basically I would like to know what the argument was meant for and if
> anyone has any objections to my removing it, and making the
> corresponding change to the existing tests, as noted in issue #293.

Please go ahead and remove it.

Jim

-- 
Jim Fulton           mailto:jim at zope.com       Python Powered!
CTO                  (540) 361-1714            http://www.python.org
Zope Corporation     http://www.zope.com       http://www.zope.org